This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -i
to squash commits (if needed).Bug fixes for about:bookmarks:
Fixes #5223
Fixes #5249
NOTE: this updates appConfig to use about:newtab for new tabs if NODE_ENV=test, which is required for our tests to run. I had unintentionally broke those (because some tests rely on URL bar having focus) when submitting #5301
Auditors: @darkdh @bbondy
Test Plan: